@sdwilsh Unless you have an objection, I'm going to close this out as fixed by the current version in Main.

@sever should we move this to VyOS project instead of VyOS Ansible Collection, since the problem here was with 1.4.0?

@kevinrausch You see the kernel and local routes as the newest version uses FRR 10.2.x T6747

In T4797#209833, @TheSin- wrote:

I’ve been using it as is since I posted this, it’s been working fantastically

In T7001#211515, @c-po wrote:

@nekocentral this is currently working as expected as all the guest agents got removed from the generic image which is shipped as rolling binary.

I totally understand the issue and need here - as I am also affected by this change. It was placed on the agenda for the next maintainer meeting.

https://github.com/vyos/vyos-build/pull/877

In T6996#211364, @Viacheslav wrote:

The 1.3.x is deprecated; I'm not expecting any fixes here.

In T4797#209833, @TheSin- wrote:

I’ve been using it as is since I posted this, it’s been working fantastically

https://github.com/vyos/vyos-1x/pull/4280

In T6998#211713, @metron2 wrote:

I had a problem with this code, but I also had a hostname that was too short for the trailing '.' check.

# remove trailing dot to ensure consistency for `vyos-hostsd-client`
if len(data_lease['hostname']) > 1 and data_lease['hostname'][-1] == '.':
    data_lease['hostname'] = data_lease['hostname'][:-1]

In T6998#211714, @metron2 wrote:

I opened a PR with these changes and tested them by modifying the file on the image. It works now. I'm guessing there isn't a testcase for this command anyway.

https://github.com/vyos/vyos-1x/pull/4277

https://github.com/vyos/vyos-1x/pull/4273

https://github.com/vyos/vyos-1x/pull/4278

I opened this mostly as a boilerplate because I think it's something valuable to have. I'm happy to run through tests if the maintainers think this is a valuable change, and I can probably expand a little bit on some of the j2. I don't want to waste time if it's something the maintainers don't agree with at a more fundamental level, I can just do the change in my local vyos with some post boot scripting.

Not sure how to actually link it here, don't think I have that permission.

tmp['address_info'] looks like

I opened a PR with these changes and tested them by modifying the file on the image. It works now. I'm guessing there isn't a testcase for this command anyway.

I had a problem with this code, but I also had a hostname that was too short for the trailing '.' check.

Essential for release.

Essential for release

Important release test

1.4 and 1.5 working

I tested the following builds using the same config noted above:

vyos-1.5-rolling-202412050007-generic-amd64.iso - works
vyos-1.5-rolling-202412060007-generic-amd64.iso - works
vyos-1.5-rolling-202412160007-generic-amd64.iso - works
vyos-1.5-rolling-202412310006-generic-amd64.iso - fails
vyos-1.5-rolling-202501031241-generic-amd64.iso - fails

Run into the same issue, including the latest self-compiled rolling from today (2025-01-04).

Changes appear trivial enough I'm going to make them now

https://github.com/vyos/vyos-1x/pull/4275

Going to need to fix testing for fw_rules as a part of my current work - so picking this up...

Needed before 6.0.0 release

@nekocentral this is currently working as expected as all the guest agents got removed from the generic image which is shipped as rolling binary.

vyos_config Integration tests under 1.4 and 1.5+ pass when run against each machine singly, so these changes may not be necessary to get integration tests running before the 6.0.0 release.