you are right , I seems to be working :
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Jun 22 2023
Jun 22 2023
a.apostoliuk changed the status of T5254: Modification of any interface setting sets MTU back to default when MTU has been inherited from a bond from Open to In progress.
Jun 21 2023
Jun 21 2023
fernando renamed T5307: QoS - traffic-class-map services from Qos - traffic-class-map services to QoS - traffic-class-map services .
I've tested it, but it works partially... if you have more than a match (for example, the same class id if necessary to match more than one DSCP),it brakes the configuration again :
Viacheslav changed the status of T5304: Containers add bind-propagation option rshared from Open to In progress.
PR https://github.com/vyos/vyos-1x/pull/2051
vyos@r14# run show conf com | match cont
set container name c1 allow-host-networks
set container name c1 description 'foof'
set container name c1 image 'busybox'
set container name c1 volume myvlm destination '/tmp'
set container name c1 volume myvlm propagation 'rshared'
set container name c1 volume myvlm source '/tmp'
set system sysctl parameter net.ipv4.tcp_congestion_control value 'bbr'
[edit]
vyos@r14#
[edit]
vyos@r14# sudo podman inspect -f '{{.Mounts}}' c1
[{bind /tmp /tmp [nosuid nodev rbind] true rshared}]
[edit]
vyos@r14#SrividyaA renamed T5306: bgp config migration failed with v6only option configured with peer-group from config migration failed with v6only option configured with peer-group to bgp config migration failed with v6only option configured with peer-group.
Jun 20 2023
Jun 20 2023
jestabro closed T5248: Ability to load config via API in JSON format, a subtask of T3441: More intelligent config loading scripts, as Resolved.
jestabro closed T5248: Ability to load config via API in JSON format, a subtask of T5263: Generalization of REST configure endpoint, as Resolved.
jestabro closed T5300: verification of port availability can return false negative on boot as Resolved.
jestabro changed the status of T5305: REST API configure operation should not be defined as async from Open to In progress.
jestabro added a comment to T5300: verification of port availability can return false negative on boot.
Viacheslav renamed T5304: Containers add bind-propagation option rshared from Containers add propagation option rshared to Containers add bind-propagation option rshared.
Jun 19 2023
Jun 19 2023
It fixes for shaper but breaks the policer
Policer uses limits in tc filter
In T4989#150726, @daniil wrote:Now the traffic limiter is broken.
interface br100 { ingress 1G-in } policy { limiter 1G-in { default { bandwidth 1gbit burst 125000000b } } }tc filter show dev br100 ingressis empty, upload traffic is not limited.
Viacheslav reopened T5295: QoS shaper incorrect rate limit the traffic, a subtask of T5048: QoS doesn't work correctly root task, as Needs testing.
Now the traffic limiter is broken.
Fixed in https://github.com/vyos/vyos-1x/pull/2047 https://vyos.dev/T5256
set qos interface eth0 egress 'test' set qos policy shaper test bandwidth '330mbit' set qos policy shaper test class 23 bandwidth '50%' set qos policy shaper test class 23 match icmpv4 ip protocol 'icmp' set qos policy shaper test default bandwidth '300mbit' set qos policy shaper test default queue-type 'fair-queue'
Viacheslav closed T5281: Add kernel options for vhost-net, a subtask of T1797: Implement DPDK Fast-Path using FRR's Alternate Forwarding Planes and VPP, as Resolved.
in the VyOS 1.4-rolling-202306190317
set qos interface eth0 egress 'test' set qos policy shaper test bandwidth '300bit' set qos policy shaper test class 100 bandwidth '150mbit' set qos policy shaper test class 100 burst '3760k' set qos policy shaper test class 100 match internal mark '100' set qos policy shaper test class 100 queue-type 'fq-codel' set qos policy shaper test default bandwidth '20mbit' set qos policy shaper test default burst '188k' set qos policy shaper test default queue-type 'fq-codel'
comimt
DEBUG/QoS: tc qdisc replace dev eth0 root handle 1: htb r2q 1 default 65 DEBUG/QoS: tc class replace dev eth0 parent 1: classid 1:1 htb rate 300 DEBUG/QoS: tc class replace dev eth0 parent 1:1 classid 1:64 htb rate 150000000 burst 3760k quantum 1514 DEBUG/QoS: tc qdisc replace dev eth0 parent 1:64 sfq DEBUG/QoS: tc class replace dev eth0 parent 1:1 classid 1:65 htb rate 20000000 burst 188k quantum 1514 prio 20 DEBUG/QoS: tc qdisc replace dev eth0 parent 1:65 sfq DEBUG/QoS: tc qdisc replace dev eth0 parent 1:64 fq_codel quantum 1514 flows 1024 interval 100 interval 100 target 5 noecn DEBUG/QoS: tc filter replace dev eth0 parent 1: protocol all handle 100 fw flowid 1:64
@MartB Could you test it? Should be fixed in vyos-1.4-rolling-202306190317-amd64.iso
Jun 18 2023
Jun 18 2023
Viacheslav changed the status of T5071: QOS-Rewrite: DSCP match missing, a subtask of T5048: QoS doesn't work correctly root task, from Open to Needs testing.
Not sure about ipv6, requires more tests, but ip should work
PR https://github.com/vyos/vyos-1x/pull/2048
Viacheslav closed T5256: QoS expects protocol number but not protocol name, a subtask of T5048: QoS doesn't work correctly root task, as Resolved.
Viacheslav closed T5295: QoS shaper incorrect rate limit the traffic, a subtask of T5048: QoS doesn't work correctly root task, as Resolved.
Sorry, I did not find that issue during my initial search.
I guess we can close this issue as duplicate.
What is the correct way to do this in phabricator?
Viacheslav added a parent task for T5071: QOS-Rewrite: DSCP match missing: T5048: QoS doesn't work correctly root task.
Viacheslav added a subtask for T5048: QoS doesn't work correctly root task: T5071: QOS-Rewrite: DSCP match missing.
The similar task https://vyos.dev/T5154
Viacheslav changed the status of T5256: QoS expects protocol number but not protocol name, a subtask of T5048: QoS doesn't work correctly root task, from In progress to Needs testing.
Viacheslav changed the status of T5256: QoS expects protocol number but not protocol name from In progress to Needs testing.
Jun 17 2023
Jun 17 2023
Viacheslav changed the status of T5296: QoS class cannot calculate correctly the default bandwidth auto, a subtask of T5048: QoS doesn't work correctly root task, from In progress to Needs testing.
Viacheslav changed the status of T5296: QoS class cannot calculate correctly the default bandwidth auto from In progress to Needs testing.
jestabro updated the task description for T5300: verification of port availability can return false negative on boot.
jestabro closed T5292: Commit error on boot when https.py is included in config daemon scripts as Not Applicable.
jestabro added a comment to T5292: Commit error on boot when https.py is included in config daemon scripts.
This was a red herring: root cause in
https://vyos.dev/T5300
jestabro updated the task description for T5300: verification of port availability can return false negative on boot.
This is most likely due to a config error on boot, thus leaving the active config different from the saved config; cf.
'verification of port availability can return false negative on boot'
https://vyos.dev/T5300
jestabro changed the status of T5300: verification of port availability can return false negative on boot from Open to In progress.
In T4989#144426, @MartB wrote:set qos policy shaper test bandwidth 100mbit set qos policy shaper test class 10 bandwidth 50%It wont be used right now if I add a class that uses a percentage, it will always use the interface speed.
The base __rate_convert should include some check if the "base" speed was already set.
Fix for match protocol https://github.com/vyos/vyos-1x/pull/2047
Viacheslav changed the status of T5256: QoS expects protocol number but not protocol name, a subtask of T5048: QoS doesn't work correctly root task, from Open to In progress.
Viacheslav changed the status of T5256: QoS expects protocol number but not protocol name from Open to In progress.
Viacheslav renamed T5256: QoS expects protocol number but not protocol name from QoS expects protocal number but not protocol name to QoS expects protocol number but not protocol name.
Viacheslav renamed T5256: QoS expects protocol number but not protocol name from Quality of Services crash with new qos policy to QoS expects protocal number but not protocol name.
It expects ip protocol 1 instead of 'ip protocol icmp' in tc
wrong generation for protocols
Viacheslav added a parent task for T5256: QoS expects protocol number but not protocol name: T5048: QoS doesn't work correctly root task.
Viacheslav added a comment to T5296: QoS class cannot calculate correctly the default bandwidth auto.
Viacheslav changed the status of T5296: QoS class cannot calculate correctly the default bandwidth auto, a subtask of T5048: QoS doesn't work correctly root task, from Open to In progress.
Viacheslav changed the status of T5296: QoS class cannot calculate correctly the default bandwidth auto from Open to In progress.
Viacheslav added a comment to T5262: Warn the user about unsaved config on reboot/shutdown attempts.
After reboot, I connect to the node and execute reboot again without any config change
But I still see a Warning, that looks like a bug in this case.
Viacheslav changed the status of T5295: QoS shaper incorrect rate limit the traffic, a subtask of T5048: QoS doesn't work correctly root task, from In progress to Needs testing.
Viacheslav changed the status of T5295: QoS shaper incorrect rate limit the traffic from In progress to Needs testing.
Jun 16 2023
Jun 16 2023
Viacheslav added a comment to T5296: QoS class cannot calculate correctly the default bandwidth auto.
If class['bandwidth'] == auto then we should get global bandwidth
jestabro triaged T5297: Utility function to check if config under node has been changed between revisions as Normal priority.
Viacheslav updated the task description for T5296: QoS class cannot calculate correctly the default bandwidth auto.
Viacheslav updated the task description for T5296: QoS class cannot calculate correctly the default bandwidth auto.
Viacheslav updated the task description for T5296: QoS class cannot calculate correctly the default bandwidth auto.
Viacheslav changed the status of T5295: QoS shaper incorrect rate limit the traffic, a subtask of T5048: QoS doesn't work correctly root task, from Open to In progress.
Viacheslav changed the status of T5295: QoS shaper incorrect rate limit the traffic from Open to In progress.
The same config in 1.3 doesn't have tc filter in 1.3
It's time to separate this task into subtasks.
Viacheslav renamed T5048: QoS doesn't work correctly root task from QoS doesn't work correctly on 1.4-rolling-202302150317 to QoS doesn't work correctly root task.