That should actually not be possible with the verify() step - looks like a bug in the code

Sure, go ahead. Thanks!

Pull request: https://github.com/vyos/vyos-1x/pull/303

I could not tell you why it was decided to be this way.

As indicated, I could not test this patch.

https://github.com/vyos/vyos-1x/pull/300

Pull request: https://github.com/vyos/vyos-1x/pull/301

This work is now completed.

@kroy could you please confirm that we can close this issue :-)

duplicate of T149 ?

I can try to tackle this if noone else is working on it.

This is the logic from my old wireless-hostapd.pl file:

https://github.com/vyos/vyos-1x/pull/299

https://github.com/vyos/vyos-1x/pull/298

This is the logic from my old wireless-hostapd.pl file:

Here is the logic from my old wireless-hostapd.pl file:

Aye, from what I see in my old wireless-hostap.pl, logic should go like this. Every "print" is output to the wlanX.cfg which serves as config input for hostapd.

PR https://github.com/vyos/vyos-1x/pull/297

Sorry, this is actually invalid as this patch is used in upstream Debian PPP

Hi @alainlamar how should the generated configuration look like?

@jjakob thank you for the detail. I will work on it.

Currently none of the offloading (gro, gso, sg, tso, ufo) settings are checked either at src/conf_mode/interfaces-ethernet.py verify() or in the module python/vyos/ifconfig/ethernet.py. Setting one of these when the driver doesn't support it will result in an unhandled exception. This may not be so disastrous when setting the options in config mode, as the commit will fail due to the exception, but will have more disastrous results when a config which has these options set is loaded into a system with NICs that don't support it - this will cause boot time commit to fail. As per T2158 and PR#272 none of these calls should result in an exception, but rather just print a warning and continue.

Fix in https://github.com/vyos/vyos-documentation/pull/234

Is there a patch to include configuration for this out there somewhere yet? I'd be interested in testing it out; can possibly help with the patch if it's started too.

I agree: the logs should reflect the actions performed to update the router following the configuration change. As this should be the same each time, we should be able to check a change with a saved replay, as a way to check that all is as should (part of the smoketest testing).

Closed due to inactivity.

Both Routers running VyOS 1.2.3

This PR still needs to be merged: https://github.com/vyos/vyatta-cfg/pull/23

The above patch breaks sorting for other nodes that contain text, not a number. We'd need some way to distinguish different node types (text, IP, number,...) and chose different sorts depending on that.

This is only for interfaces, T2175 is for all frr related daemons .. other features need a ticket

In the current 1.3 branch the original issue was resolved and added STOP script support. It is necessary to test this and review the possibility to backport the solution into 1.2.

Is this only for interfaces or for other rewrites (NAT, Firewall, BGP) too? If so, I'll add all the related tasks.

Why we can't enable this feature by default.
A lot of customers don't use it, and announce their BGP prefix with "network x.x.x.x"
Imagine if you don't have configuration "redistribute connected" or "redistribute static".
If this feature enabled by default in the new release - you update the VyOS, reboot it and lose access to the router.
Because there are no routes /24 as directly connected. Also, you can use more-spec prefixes (/28 /29 /25), not /24.
Prefixes will disappear from the announcements ISPs.
It's impossible to figure out quickly what happened.

I tried adding it but failed miserably. This should best be done with the entire BGP rewrite.