Page MenuHomeVyOS Platform
Feed Search

Apr 14 2021

jestabro added a comment to T3474: Revisit storing syntax version of interface definitions in XML file.

The suggested resolution is to define an include file with the syntaxVersion element. The syntaxVersion element contains the component name and version number; the including interface definition file corresponds to the conf_mode script. Hence, this defines a mapping

Apr 14 2021, 10:53 PM · VyOS 1.4 Sagitta (1.4.0-epa1)
jestabro committed rVYOSONEXbafdc46e7af9: xml: T3475: disable processing of syntaxVersion element.
Apr 14 2021, 9:28 PM
jestabro renamed T3475: XML dictionary cache unable to process syntaxVersion elements from XML dictionary cache unable to process syntaxVersion element to XML dictionary cache unable to process syntaxVersion elements.
Apr 14 2021, 7:30 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro updated the task description for T3475: XML dictionary cache unable to process syntaxVersion elements.
Apr 14 2021, 6:47 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro updated the task description for T3475: XML dictionary cache unable to process syntaxVersion elements.
Apr 14 2021, 6:31 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro added a subtask for T3475: XML dictionary cache unable to process syntaxVersion elements: T3474: Revisit storing syntax version of interface definitions in XML file.
Apr 14 2021, 6:30 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro added a parent task for T3474: Revisit storing syntax version of interface definitions in XML file: T3475: XML dictionary cache unable to process syntaxVersion elements.
Apr 14 2021, 6:30 PM · VyOS 1.4 Sagitta (1.4.0-epa1)
jestabro added a subtask for T1962: Add syntax version to schema: T3475: XML dictionary cache unable to process syntaxVersion elements.
Apr 14 2021, 6:28 PM · VyOS 1.3 Equuleus (1.3.0)
jestabro added a parent task for T3475: XML dictionary cache unable to process syntaxVersion elements: T1962: Add syntax version to schema.
Apr 14 2021, 6:28 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro triaged T3475: XML dictionary cache unable to process syntaxVersion elements as Normal priority.
Apr 14 2021, 6:28 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro updated the task description for T3474: Revisit storing syntax version of interface definitions in XML file.
Apr 14 2021, 6:15 PM · VyOS 1.4 Sagitta (1.4.0-epa1)
jestabro added a subtask for T1962: Add syntax version to schema: T3474: Revisit storing syntax version of interface definitions in XML file.
Apr 14 2021, 6:13 PM · VyOS 1.3 Equuleus (1.3.0)
jestabro added a parent task for T3474: Revisit storing syntax version of interface definitions in XML file: T1962: Add syntax version to schema.
Apr 14 2021, 6:13 PM · VyOS 1.4 Sagitta (1.4.0-epa1)
jestabro triaged T3474: Revisit storing syntax version of interface definitions in XML file as Normal priority.
Apr 14 2021, 6:13 PM · VyOS 1.4 Sagitta (1.4.0-epa1)

Apr 1 2021

jestabro added a comment to T2838: Ethernet device names changing, multiple hw-id being added.

https://github.com/vyos/vyatta-cfg-system/pull/144

Apr 1 2021, 4:46 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro added a comment to T2838: Ethernet device names changing, multiple hw-id being added.

There are two issues in this task (1) reordering of interfaces (2) redundant hw-id entries due to vyatta_net_name not parsing quoted values. A quick fix for (2) will be a PR for vyatta-cfg-system; the general issues the bug raises, regarding quoted values in configtree, will be addressed in the subtasks.

Apr 1 2021, 4:27 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta

Mar 31 2021

jestabro claimed T2838: Ethernet device names changing, multiple hw-id being added.
Mar 31 2021, 6:46 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro moved T3445: vyos-1x build include not all nodes from In Progress to Finished on the VyOS 1.3 Equuleus board.
Mar 31 2021, 5:39 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro closed T3445: vyos-1x build include not all nodes as Resolved.
Mar 31 2021, 5:38 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro moved T3445: vyos-1x build include not all nodes from Need Triage to In Progress on the VyOS 1.3 Equuleus board.
Mar 31 2021, 5:04 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro committed rVYOSONEX4ae739188753: xml: T3445: avoid false positive on element references; use path name.
Mar 31 2021, 5:03 PM
jestabro moved T3445: vyos-1x build include not all nodes from Open to In Progress on the VyOS 1.4 Sagitta board.
Mar 31 2021, 4:59 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro added a project to T3445: vyos-1x build include not all nodes: VyOS 1.3 Equuleus.
Mar 31 2021, 4:58 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro triaged T3445: vyos-1x build include not all nodes as High priority.
Mar 31 2021, 4:56 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro changed the status of T3445: vyos-1x build include not all nodes from Open to Needs testing.
Mar 31 2021, 4:55 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro committed rVYOSONEXf22fa8e6454b: xml: T3445: avoid false positive on element references; use path name.
Mar 31 2021, 4:55 PM
jestabro claimed T3445: vyos-1x build include not all nodes.
Mar 31 2021, 12:54 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta

Mar 30 2021

jestabro renamed T3441: More intelligent config loading scripts from More inteligent config loading scripts to More intelligent config loading scripts.
Mar 30 2021, 12:12 PM · VyOS Rolling

Mar 28 2021

jestabro closed T3440: HTTP API: give uvicorn time to initialize before restarting Nginx proxy as Resolved.
Mar 28 2021, 9:26 PM · VyOS 1.4 Sagitta
jestabro committed rVYOSONEX889e16a77517: http-api: T3440: give uvicorn time to initialize before starting Nginx.
Mar 28 2021, 9:26 PM
jestabro triaged T3440: HTTP API: give uvicorn time to initialize before restarting Nginx proxy as High priority.
Mar 28 2021, 9:21 PM · VyOS 1.4 Sagitta
jestabro closed T3426: add support for script arguments to vyos-configd as Resolved.
Mar 28 2021, 9:15 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta

Mar 26 2021

jestabro moved T2397: HTTP API: export OpenAPI definition from Open to Finished on the VyOS 1.4 Sagitta board.
Mar 26 2021, 8:50 PM · VyOS 1.4 Sagitta
jestabro closed T2397: HTTP API: export OpenAPI definition as Resolved.

This is resolved by T3412.

Mar 26 2021, 8:50 PM · VyOS 1.4 Sagitta
jestabro closed T3412: HTTP API: move to FastAPI as web framework, a subtask of T2395: HTTP API move to flask/flask-restx as microframework, as Resolved.
Mar 26 2021, 8:49 PM · VyOS 1.3 Equuleus (1.3.0)
jestabro closed T3412: HTTP API: move to FastAPI as web framework, a subtask of T2397: HTTP API: export OpenAPI definition, as Resolved.
Mar 26 2021, 8:49 PM · VyOS 1.4 Sagitta
jestabro closed T3412: HTTP API: move to FastAPI as web framework as Resolved.
Mar 26 2021, 8:49 PM · VyOS 1.4 Sagitta
jestabro committed rVYOSONEX0125fff200ef: http api: T3412: use FastAPI as web framework; support application/json.
Mar 26 2021, 8:47 PM

Mar 25 2021

jestabro committed rVYOSONEX46a3920aba39: configd: T3426: include bgp, isis, ospf and static protocols in processing.
Mar 25 2021, 9:55 PM
jestabro committed rVYOSONEXb3d914edcb50: configd: T3426: add support for script arguments to vyos-configd.
Mar 25 2021, 9:55 PM
jestabro added a comment to T3412: HTTP API: move to FastAPI as web framework.

Draft PR linked below; it is a draft pending the addition of a supporting package (vyos-http-api-tools). All data validation for application/json requests is done implicitly using Pydantic models/validators; for multipart forms requests, all explicit validation has been moved out of the endpoint function bodies and into the middleware --- this is a pedantic block of code, but allows consolidation and review of all manual checks. An OpenAPI 3.0.2 schema is automatically generated and presented at server-name/docs (Swagger) and server-name/redoc (ReDoc version; slightly more pleasing to the eye).

Mar 25 2021, 1:31 AM · VyOS 1.4 Sagitta

Mar 24 2021

jestabro committed rVYOSONEX5501e5f1de02: configd: T3426: correct pass_through function for scripts with args.
Mar 24 2021, 2:14 AM

Mar 23 2021

jestabro committed rVYOSONEX93c07ea1edff: configd: T3426: check script name against include_set, not exclude_set.
Mar 23 2021, 8:27 PM
jestabro triaged T3426: add support for script arguments to vyos-configd as High priority.
Mar 23 2021, 8:22 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta

Mar 22 2021

jestabro committed rVYOSONEXeeb9687bb9aa: configd: T3302: check vyos-config-status to determine if in boot session.
Mar 22 2021, 3:13 PM
jestabro moved T3284: merge/load fail silently if unable to resolve host from Open to Finished on the VyOS 1.4 Sagitta board.
Mar 22 2021, 1:09 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro closed T3284: merge/load fail silently if unable to resolve host as Resolved.
Mar 22 2021, 1:09 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro closed T3402: Add VyOS programming library for operational level commands as Resolved.
Mar 22 2021, 12:59 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro committed rVYOSONEX9687e5a076f7: configquery: T3402: add library for querying config values from op mode.
Mar 22 2021, 12:57 PM

Mar 21 2021

jestabro added a comment to T3402: Add VyOS programming library for operational level commands.

@jack9603301 It is not a matter of different codes, but rather what python libraries have been provided so far: the focus has been on abstracting the config session, in several directions, and previously there had not been a use case for reading config settings from op mode.

Mar 21 2021, 8:50 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro changed the status of T3402: Add VyOS programming library for operational level commands from Open to Needs testing.
Mar 21 2021, 8:47 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta

Mar 18 2021

jestabro changed the status of T3411: Extend the redirect_stdout context manager in vyos-configd to redirect stdout from subprocesses, a subtask of T3302: Make vyos-configd relay stdout from scripts to the user's console, from Unknown Status to Resolved.
Mar 18 2021, 8:43 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro changed the status of T3411: Extend the redirect_stdout context manager in vyos-configd to redirect stdout from subprocesses from Unknown Status to Resolved.
Mar 18 2021, 8:43 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro committed rVYOSONEXd287cebbc95f: configd: T3411: redirect stdout from scripts to console; to file on boot.
Mar 18 2021, 8:42 PM

Mar 17 2021

jestabro changed the status of T3412: HTTP API: move to FastAPI as web framework, a subtask of T2395: HTTP API move to flask/flask-restx as microframework, from In progress to Needs testing.
Mar 17 2021, 9:20 PM · VyOS 1.3 Equuleus (1.3.0)
jestabro changed the status of T3412: HTTP API: move to FastAPI as web framework, a subtask of T2397: HTTP API: export OpenAPI definition, from In progress to Needs testing.
Mar 17 2021, 9:20 PM · VyOS 1.4 Sagitta
jestabro changed the status of T3412: HTTP API: move to FastAPI as web framework from In progress to Needs testing.
Mar 17 2021, 9:20 PM · VyOS 1.4 Sagitta

Mar 16 2021

jestabro closed T3411: Extend the redirect_stdout context manager in vyos-configd to redirect stdout from subprocesses, a subtask of T3302: Make vyos-configd relay stdout from scripts to the user's console, as Unknown Status.
Mar 16 2021, 5:13 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro closed T3411: Extend the redirect_stdout context manager in vyos-configd to redirect stdout from subprocesses as Unknown Status.
Mar 16 2021, 5:13 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro committed rVYOSONEX27d6b5a3b3bf: configd: T3411: revert to using explicit_print on ConfigError.
Mar 16 2021, 5:10 PM
jestabro committed rVYOSONEXfb2480e8a5c5: configd: T3411: revise redirect to capture stdout from subprocesses.
Mar 16 2021, 5:10 PM
jestabro added a comment to T3412: HTTP API: move to FastAPI as web framework.

There are two versions that have been developed, reasonably feature complete, pending testing. One presents an OpenAPI schema of application/x-www-form-urlencoded (multipart forms); the other, application/json. The latter uses middleware (strictly speaking, a custom request and route class, instead of the Starlette middleware capability, although that may change) to intercept multipart requests, so as to remain backwards compatible.

Mar 16 2021, 5:05 PM · VyOS 1.4 Sagitta
jestabro added a subtask for T2395: HTTP API move to flask/flask-restx as microframework: T3412: HTTP API: move to FastAPI as web framework.
Mar 16 2021, 4:54 PM · VyOS 1.3 Equuleus (1.3.0)
jestabro added a subtask for T2397: HTTP API: export OpenAPI definition: T3412: HTTP API: move to FastAPI as web framework.
Mar 16 2021, 4:54 PM · VyOS 1.4 Sagitta
jestabro added parent tasks for T3412: HTTP API: move to FastAPI as web framework: T2395: HTTP API move to flask/flask-restx as microframework, T2397: HTTP API: export OpenAPI definition.
Mar 16 2021, 4:54 PM · VyOS 1.4 Sagitta
jestabro changed the status of T3412: HTTP API: move to FastAPI as web framework from Open to In progress.
Mar 16 2021, 4:53 PM · VyOS 1.4 Sagitta
jestabro added a comment to T3411: Extend the redirect_stdout context manager in vyos-configd to redirect stdout from subprocesses.

https://github.com/vyos/vyos-1x/pull/777

Mar 16 2021, 4:12 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro changed the status of T3411: Extend the redirect_stdout context manager in vyos-configd to redirect stdout from subprocesses, a subtask of T3302: Make vyos-configd relay stdout from scripts to the user's console, from In progress to Needs testing.
Mar 16 2021, 12:55 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro changed the status of T3411: Extend the redirect_stdout context manager in vyos-configd to redirect stdout from subprocesses from In progress to Needs testing.

https://github.com/jestabro/vyos-1x/tree/stdout_redirected

Mar 16 2021, 12:55 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro changed the status of T3302: Make vyos-configd relay stdout from scripts to the user's console from Unknown Status to Resolved.
Mar 16 2021, 12:44 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro changed the status of T3302: Make vyos-configd relay stdout from scripts to the user's console, a subtask of T2347: During commit, any script output directed to stdout will contain path, from Unknown Status to Resolved.
Mar 16 2021, 12:44 PM · VyOS 1.3 Equuleus (1.3.0)
jestabro removed a project from T3302: Make vyos-configd relay stdout from scripts to the user's console: VyOS 1.3 Equuleus.
Mar 16 2021, 12:43 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro added a subtask for T3302: Make vyos-configd relay stdout from scripts to the user's console: T3411: Extend the redirect_stdout context manager in vyos-configd to redirect stdout from subprocesses.
Mar 16 2021, 12:42 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro added a parent task for T3411: Extend the redirect_stdout context manager in vyos-configd to redirect stdout from subprocesses: T3302: Make vyos-configd relay stdout from scripts to the user's console.
Mar 16 2021, 12:42 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro changed the status of T3411: Extend the redirect_stdout context manager in vyos-configd to redirect stdout from subprocesses from Open to In progress.
Mar 16 2021, 12:42 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta

Mar 15 2021

jestabro added a comment to T3284: merge/load fail silently if unable to resolve host.

Thanks, @erkin --- I'm sure you can cherry-pick from 1.4 to 1.3; 'backporting' is not quite the right word, as it is development branch to stable branch. I really like this solution to the mess that was remote.py.

Mar 15 2021, 1:24 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta

Mar 12 2021

jestabro added a comment to T3284: merge/load fail silently if unable to resolve host.

Assuming T3356 can be backported to equuleus, this fix will not be needed.

Mar 12 2021, 5:20 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta

Feb 26 2021

jestabro changed the status of T3357: HTTP-API redirect from http correct https port from Unknown Status to Resolved.
Feb 26 2021, 10:20 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro committed rVYOSONEX66b399b3f7ab: https: T3357: redirect http request on non-standard https port.
Feb 26 2021, 10:20 PM
jestabro closed T3357: HTTP-API redirect from http correct https port as Unknown Status.
Feb 26 2021, 7:16 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro committed rVYOSONEX2c798f7b9064: https: T3357: redirect http request on non-standard https port.
Feb 26 2021, 7:15 PM
jestabro added a comment to T3357: HTTP-API redirect from http correct https port.

Thanks @rob, it is true that nginx is not redirecting to a non canonical https port. Using the nginx custom https status code 497, this can be added; I will update the template accordingly.

Feb 26 2021, 5:03 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro claimed T3357: HTTP-API redirect from http correct https port.
Feb 26 2021, 3:08 AM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro committed rVYOSONEX77a16626802a: configd: T3302: set mode correctly on open for redirect.
Feb 26 2021, 2:55 AM

Feb 23 2021

jestabro closed T3302: Make vyos-configd relay stdout from scripts to the user's console, a subtask of T2347: During commit, any script output directed to stdout will contain path, as Unknown Status.
Feb 23 2021, 9:05 PM · VyOS 1.3 Equuleus (1.3.0)
jestabro closed T3302: Make vyos-configd relay stdout from scripts to the user's console as Unknown Status.
Feb 23 2021, 9:05 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro committed rVYOSONEXb4eb58594158: configd: T3302: redirect script stdout/err to file on boot.
Feb 23 2021, 9:02 PM
jestabro reopened T3302: Make vyos-configd relay stdout from scripts to the user's console, a subtask of T2347: During commit, any script output directed to stdout will contain path, as Open.
Feb 23 2021, 9:01 PM · VyOS 1.3 Equuleus (1.3.0)
jestabro reopened T3302: Make vyos-configd relay stdout from scripts to the user's console as "Open".

If commit is not initiated from a 'live' session (for example, on boot), then redirected stdout/err should go to a file.

Feb 23 2021, 9:01 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta

Feb 18 2021

jestabro changed Is it a breaking change? from none to compatible on T3259: many dnat rules makes the vyos http api crash, even showConfig op timeouts.
Feb 18 2021, 9:48 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro closed T3259: many dnat rules makes the vyos http api crash, even showConfig op timeouts as Resolved.
Feb 18 2021, 9:47 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro moved T3259: many dnat rules makes the vyos http api crash, even showConfig op timeouts from In Progress to Finished on the VyOS 1.3 Equuleus board.
Feb 18 2021, 9:47 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro committed rVYOSONEXc0bc1782f3c9: configsession: T3259: avoid deadlock when data fills stdout pipe.
Feb 18 2021, 9:44 PM
jestabro moved T3302: Make vyos-configd relay stdout from scripts to the user's console from Need Triage to In Progress on the VyOS 1.3 Equuleus board.
Feb 18 2021, 8:09 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro closed T3302: Make vyos-configd relay stdout from scripts to the user's console, a subtask of T2347: During commit, any script output directed to stdout will contain path, as Unknown Status.
Feb 18 2021, 8:09 PM · VyOS 1.3 Equuleus (1.3.0)
jestabro closed T3302: Make vyos-configd relay stdout from scripts to the user's console as Unknown Status.
Feb 18 2021, 8:08 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro committed rVYOSONEX8f50b3dd94f4: configd: T3302: redirect stdout/stderr from scripts to console.
Feb 18 2021, 8:08 PM
jestabro moved T3259: many dnat rules makes the vyos http api crash, even showConfig op timeouts from Backport Candidates to In Progress on the VyOS 1.3 Equuleus board.
Feb 18 2021, 12:44 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro moved T3259: many dnat rules makes the vyos http api crash, even showConfig op timeouts from Open to Finished on the VyOS 1.4 Sagitta board.
Feb 18 2021, 12:43 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta
jestabro moved T3259: many dnat rules makes the vyos http api crash, even showConfig op timeouts from Need Triage to Backport Candidates on the VyOS 1.3 Equuleus board.
Feb 18 2021, 12:42 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.4 Sagitta